Skip to content

NW | 2026-mar-sdc | Zabihollah Namazi | Sprint 4 | implement cowsay#444

Open
ZabihollahNamazi wants to merge 1 commit into
CodeYourFuture:mainfrom
ZabihollahNamazi:cowsay-sprint4
Open

NW | 2026-mar-sdc | Zabihollah Namazi | Sprint 4 | implement cowsay#444
ZabihollahNamazi wants to merge 1 commit into
CodeYourFuture:mainfrom
ZabihollahNamazi:cowsay-sprint4

Conversation

@ZabihollahNamazi
Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

could you please check the code ?
thanks

@ZabihollahNamazi ZabihollahNamazi added 📅 Sprint 4 Assigned during Sprint 4 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 28, 2026
Copy link
Copy Markdown
Contributor

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly complete, good start

Comment thread implement-cowsay/cow.py
import argparse

#getting avalble animal list
animals = [a for a in dir(cowsay) if not a.startswith("__") and callable(getattr(cowsay, a))]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is maybe an easier way to access this than filtering over everything in the package. Can you have a look at the docs and see if you find anything?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 4 Assigned during Sprint 4 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants